From f6c08967abe6972a081ff1ba1dff3af1ec3583c2 Mon Sep 17 00:00:00 2001 From: mattf Date: Wed, 23 Sep 2009 17:10:21 +0000 Subject: [PATCH] Rolled back vicidial.php window.open changes for web forms updated other scripts to remove SELECT * git-svn-id: svn://192.168.202.10@1236 3d104415-ff17-0410-8863-d5cf3c621b8a --- www/vicidial/AST_timeonVDADall.php | 2 +- www/vicidial/admin_search_lead.php | 12 +++++++----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/www/vicidial/AST_timeonVDADall.php b/www/vicidial/AST_timeonVDADall.php index f5078b54..77e10374 100644 --- a/www/vicidial/AST_timeonVDADall.php +++ b/www/vicidial/AST_timeonVDADall.php @@ -279,7 +279,7 @@ else #if ( (eregi('ALL-ACTIVE',$group_string)) and ($with_inbound=='O') and ($outbound_autodial_active > 0) ) # {$with_inbound='N';} -$stmt="select * from vicidial_user_groups;"; +$stmt="select user_group from vicidial_user_groups;"; $rslt=mysql_query($stmt, $link); if (!isset($DB)) {$DB=0;} if ($DB) {echo "$stmt\n";} diff --git a/www/vicidial/admin_search_lead.php b/www/vicidial/admin_search_lead.php index de6e60b9..b412812c 100644 --- a/www/vicidial/admin_search_lead.php +++ b/www/vicidial/admin_search_lead.php @@ -20,6 +20,7 @@ # 90310-2146 - Added admin header # 90508-0644 - Changed to PHP long tags # 90917-2307 - Added alternate phone number searching option +# 90921-0713 - Removed select * # require("dbconnect.php"); @@ -57,6 +58,7 @@ $STARTtime = date("U"); $TODAY = date("Y-m-d"); $NOW_TIME = date("Y-m-d H:i:s"); +$vicidial_list_fields = 'lead_id,entry_date,modify_date,status,user,vendor_lead_code,source_id,list_id,gmt_offset_now,called_since_last_reset,phone_code,phone_number,title,first_name,middle_initial,last_name,address1,address2,address3,city,state,province,postal_code,country_code,gender,date_of_birth,alt_phone,email,security_phrase,comments,called_count,last_local_call_time,rank,owner'; $stmt="SELECT count(*) from vicidial_users where user='$PHP_AUTH_USER' and pass='$PHP_AUTH_PW' and user_level > 7 and modify_leads='1';"; if ($DB) {echo "|$stmt|\n";} @@ -161,7 +163,7 @@ else if ($vendor_id) { - $stmt="SELECT * from vicidial_list where vendor_lead_code='" . mysql_real_escape_string($vendor_id) . "'"; + $stmt="SELECT $vicidial_list_fields from vicidial_list where vendor_lead_code='" . mysql_real_escape_string($vendor_id) . "'"; } else { @@ -169,18 +171,18 @@ else { if ($alt_phone_search=="Yes") { - $stmt="SELECT * from vicidial_list where phone_number='" . mysql_real_escape_string($phone) . "' or alt_phone='" . mysql_real_escape_string($phone) . "' or address3='" . mysql_real_escape_string($phone) . "'"; + $stmt="SELECT $vicidial_list_fields from vicidial_list where phone_number='" . mysql_real_escape_string($phone) . "' or alt_phone='" . mysql_real_escape_string($phone) . "' or address3='" . mysql_real_escape_string($phone) . "'"; } else { - $stmt="SELECT * from vicidial_list where phone_number='" . mysql_real_escape_string($phone) . "'"; + $stmt="SELECT $vicidial_list_fields from vicidial_list where phone_number='" . mysql_real_escape_string($phone) . "'"; } } else { if ($lead_id) { - $stmt="SELECT * from vicidial_list where lead_id='" . mysql_real_escape_string($lead_id) . "'"; + $stmt="SELECT $vicidial_list_fields from vicidial_list where lead_id='" . mysql_real_escape_string($lead_id) . "'"; } else { @@ -203,7 +205,7 @@ else if ( ($SQLctA > 0) or ($SQLctB > 0) ) {$andB = 'and';} $userSQL = "$andB user='" . mysql_real_escape_string($user) . "'"; } - $stmt="SELECT * from vicidial_list where $statusSQL $list_idSQL $userSQL"; + $stmt="SELECT $vicidial_list_fields from vicidial_list where $statusSQL $list_idSQL $userSQL"; } else {